Fix consecutive perfect curve segments not being loaded properly #12310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this completely close the mentioned issue? |
|
The issue talks about usability concerns in the comments that are not addressed here. As it stands 4-point "perfect curves"(that fall back to bezier calculation) can still be created and will be reverted to bezier on reload. |
smoogipoo
added
area:beatmap-parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11885
Prior to his PR, trying to load(or undo/redo) consecutive (valid 3-point) perfect-curve segments like this:
results in all control points being reverted to bezier:
This PR fixes this issue by always encoding perfect curves as explicit segments.
Test coverage is provided by the extended test as well as
LegacyBeatmapEncoderTest.TestEncodeDecodeStability(), which usesmulti-segment-slider.osu