-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to switch tournaments to the SetupScreen #11118
Conversation
If it requires a restart, please trigger the restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this will probably require UX considerations as to what happens if you choose another tournament. Getting booted from the game outright probably won't be the best option.
Yeah I agree. I'll be looking into something that will at worst reload the scenes to refresh the videos. Reading the bracket on switch seems a bit more complicated than I had anticipated. For now I have addressed the review comments |
At very least this should have a temporary exit procedure (even if it doesn't automatically restart the game). You can probably check how |
I got the panel so far changed so it now also contains a close button and it uses As for restarting, I'm not quite sure how to go about that. I tried adding the |
This also adds conditional checks for displaying the "Close osu!" button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should do for now.
This adds an extra entry to the setup screen that allows the user to switch the tournaments in the client instead of using the
tournament.ini
.Currently requires a restart to apply the changes.