Downloaded osu!catch replay show different result

[GSculerlor]

Describe the bug:
Downloading replay for osu!catch will give you different rank and accuracy compared with the actual replay.

Screenshots or videos showing encountered issue: https://streamable.com/1kzkx

osu!lazer version: 2019.1021.0

[bdach]

Even though it's catch, I suppose this still falls within scope of #5514; closing as duplicate.

[GSculerlor]

I personally think that's different issue since 5514 is related to timing and gameplay problem and this issue is caused by in lazer osu!catch is read Perfect and Miss value when on replay from stable it have Great, Good, Meh, and Miss. But I think adding this issue to 5514's scope is make sense since that issue is bit too general

[smoogipoo]

Definitely different than #5514, #5514 covers actual gameplay/scoring/rank, while this seems like either accuracy isn't calculated correctly or imported legacy scores aren't upgraded correctly.

[ekrctb]

Accuracy is calculated as (num300 + num100 + num50) / (max300 + max100 + max50) in stable whereas in lazer it is calculated as (300 * num300 + 30 * num100 + 10 * num50) / (300 * max300 + 30 * max100 + 10 * max50).
The rank assignment (S/A/B/C...) uses a different threshold as well.
Is the direction to match lazer to stable?

[peppy]

@ekrctb where are you seeing the accuracy calculation difference? on a quick check that doesn't look to be the case (accuracy uses the baseScore ratio, which uses numeric hit results)

osu/osu.Game/Rulesets/Scoring/ScoreProcessor.cs

Line 493 in 7d32490

baseScore += count * Judgement.ToNumericResult(result);

osu/osu.Game/Rulesets/Scoring/ScoreProcessor.cs

Lines 232 to 233 in 7d32490

	double rollingAccuracyRatio = rollingMaxBaseScore > 0 ? baseScore / rollingMaxBaseScore : 1;
	double accuracyRatio = maxBaseScore > 0 ? baseScore / maxBaseScore : 1;

[ekrctb]

@peppy The expression for lazer was wrong (tick results are scored 30, 10

osu/osu.Game/Rulesets/Judgements/Judgement.cs

Lines 144 to 148 in f41e34a

	case HitResult.SmallTickHit:
	return 10;
	case HitResult.LargeTickHit:
	return 30;

). Anyways, the difference is that lazer uses weighted sum but stable uses unweighted sum.

[peppy]

Right, I read your message back-to-front, it looks more correct now that I re-read. I'm not immediately sure of the correct direction here, would need to look into it further. @smoogipoo may have a better idea.