Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended settings sidebar cuts off text #21617

Open
Tracked by #3504
its5Q opened this issue Dec 12, 2022 · 2 comments
Open
Tracked by #3504

Extended settings sidebar cuts off text #21617

its5Q opened this issue Dec 12, 2022 · 2 comments

Comments

@its5Q
Copy link
Contributor

its5Q commented Dec 12, 2022

Type

Cosmetic

Bug description

In certain languages, for example, Ukrainian, Russian, Portugese and Japanese, the labels of settings categories overflow out of the expanded sidebar panel and get cut off. My solution would be to increase EXPANDED_WIDTH to 240px, it would look something like that:

Before After

But for some reason, it makes 8 visual tests fail (all in TestSceneKeyBindingPanel). However, when launching the test client to observe what could be breaking them, those tests pass successfully, besides one that is probably broken, I will make a separate issue for it.

I've attached logs of those failing tests in Rider, and a video of those tests passing in the test client.
My machine is a 2020 Macbook Air M1 running MacOS 13.0.

Screenshots or videos

2022-12-12.18-46-29.mp4

Version

commit 731184e

Logs

Test Output for TestBindingMouseWheelToNonGameplay.Zehirab.txt
Test Output for TestBindingSingleKeyWithModifier.Popihuw.txt
Test Output for TestBindingSingleModifier.Benovez.txt
Test Output for TestClearButtonOnBindings.Nepemaz.txt
Test Output for TestClickRowSelectsFirstBinding.Wenikiw.txt
Test Output for TestFilteringHidesResetSectionButtons.Wykylez.txt
Test Output for TestResetAllBindingsButton.Fehepyq.txt
Test Output for TestSingleBindingResetButton.Macezup.txt

@Theighlin
Copy link

Duplicate of #15452

@its5Q
Copy link
Contributor Author

its5Q commented Dec 12, 2022

Duplicate of #15452

#3504 is similar too, but in this issue I'm trying to figure out how these tests mysteriously fail, and why they pass when ran in the test client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants