Mod "Flashlight" does not cover the overlay layer of storyboards

[cdwcgt]

Type

Game behaviour

Bug description

It seen lazer won't hide foreground storyborad object when FL open

beatmap link: https://osu.ppy.sh/beatmapsets/1405100#mania/2897720

Screenshots or videos

Version

2022.501.0-lazer

Logs

runtime.log

[peppy]

I'm not immediately looking into this, but the issue lies in the ordering of layers:

Flashlight is added inside the DrawableRuleset:

osu/osu.Game/Rulesets/Mods/ModFlashlight.cs

Line 86 in 82f9ad6

drawableRuleset.KeyBindingInputManager.Add(flashlight);

Storyboard's overlay layer is being added to the Player overlay content:

osu/osu.Game/Screens/Play/Player.cs

Line 395 in cbd1169

DimmableStoryboard.OverlayLayerContainer.CreateProxy(),

Some reorganisation will need to be done, not sure in which direction.

[frenzibyte]

An idea that might work better here is to proxy the drawableRuleset.Overlays container to appear over the storyboard's overlay layer and change ModFlashlight to use that instead.