Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading states of nested overlays #11427

Open
peppy opened this issue Jan 5, 2021 · 2 comments
Open

Fix loading states of nested overlays #11427

peppy opened this issue Jan 5, 2021 · 2 comments
Labels
area:overlays priority:2 Moderately important. Relied on by some users or impeding the usability of the game type:cosmetic

Comments

@peppy
Copy link
Member

peppy commented Jan 5, 2021

Ranking and dashboard overlay have this loadDisplay logic which loads a sub component. This sub component is flowing (auto size y) content which usually has a load state. Currently there is no sane way to show a "loading" overlay due to the fact that the vertical size could be zero or changing.

I propose that FullScreenOverlay (or a derived class) exposes a bindable loading state (or something equivalent) to allow these sub components to set the state and have the parent manage the loading display. Both of the above overlays mentioned already have a loading display which could be used for this purpose.

@EVAST9919
Copy link
Contributor

So basically FullScreenOverlay should have loadDisplay and a Bindable so each sub-component could use it instead of each sub-component having it's own loadDisplay ?

@peppy
Copy link
Member Author

peppy commented Jan 11, 2021

Something like that. Maybe utilising OngoingOperationTracker that was introduced in multiplayer recently.

@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the game label Apr 9, 2021
@peppy peppy removed this from the February 2021 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:overlays priority:2 Moderately important. Relied on by some users or impeding the usability of the game type:cosmetic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants