Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Account #7948

Merged
merged 18 commits into from
Sep 8, 2022
Merged

Update Account #7948

merged 18 commits into from
Sep 8, 2022

Conversation

Furdox
Copy link
Contributor

@Furdox Furdox commented Sep 4, 2022 •
edited
Loading

Added the fact that usernames cannot be taken away if that account has any ranked beatmaps. (A user on Reddit warned me that support told them that.)

Self-check

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

in the request, there are unrelated commits about an owc translation but was really barebones and I just didn't want to translate it, so it gets deleted. Doesn't actually affect the final result.

@Furdox Furdox changed the title Add the fact that usernames cannot be taken away if that account has ranked beatmaps. [EN-FR] Add the fact that usernames cannot be taken away if that account has ranked beatmaps. Sep 4, 2022
@Furdox Furdox changed the title [EN-FR] Add the fact that usernames cannot be taken away if that account has ranked beatmaps. [EN-FR] Update Account Sep 4, 2022
@peppy
Copy link
Member

peppy commented Sep 4, 2022

@Ephemeralis please confirm this is some unwritten rule I've never heard of.

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022 •
edited
Loading

@peppy If that rule doesn't exist, it could be created to make less confusion.

@cl8n
Copy link
Member

cl8n commented Sep 4, 2022

osu-web won't let a name be taken if it has badges or ranked maps. https://github.com/ppy/osu-web/blob/851eb313e6c1ac7a3de58799a13ae0f6f58a4dac/app/Libraries/UsernameValidation.php#L81-L112

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

@cl8n That means I could also add the badge requirement, I'll go do that.

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

Wait. If I just say "user badges", people will get confused. What's "badge" exactly? The little banners right below the name for winning tournaments?

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022 •
edited
Loading

I'll go to bed. I'll probably check the answer tommorow and edit the commit accordingly.

@Furdox Furdox marked this pull request as draft September 4, 2022 03:33
@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

Dang, still no answer.

@Walavouchey
Copy link
Member

Wait. If I just say "user badges", people will get confused. What's "badge" exactly? The little banners right below the name for winning tournaments?

"profile badge" https://osu.ppy.sh/wiki/fr/Community/Profile_badge

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

Wait. If I just say "user badges", people will get confused. What's "badge" exactly? The little banners right below the name for winning tournaments?

"profile badge" https://osu.ppy.sh/wiki/fr/Community/Profile_badge

oh ok, making the changes.

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

Updated commits.

@Furdox Furdox marked this pull request as ready for review September 4, 2022 18:21
@Walavouchey Walavouchey changed the title [EN-FR] Update Account Update Account Sep 4, 2022
Furdox and others added 2 commits September 4, 2022 17:29
@Furdox
Update fr.md
923f379
@Furdox @Walavouchey
Update wiki/Help_centre/Account/en.md
f5045ae 
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

wait, accidental commit. wanted to add a comment to a suggestion but github moved to the top of my phone, pressing the accept button.

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

I can't revert the commit...

@Furdox Furdox changed the title Update Account [EN-FR] Update Account Sep 4, 2022
@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

welp, I guess it's gonna be formal. lemme do the translation and fix the english link.

@Furdox
Copy link
Contributor Author

Furdox commented Sep 4, 2022

Done.

@Furdox
Copy link
Contributor Author

Furdox commented Sep 5, 2022

The links still somehow fails some check, will need a reviewer.

@Walavouchey Walavouchey changed the title [EN-FR] Update Account Update Account Sep 5, 2022
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 5, 2022
Walavouchey
Walavouchey reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@Walavouchey Walavouchey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs check from eph, otherwise ok

@Furdox
Copy link
Contributor Author

Furdox commented Sep 6, 2022

Thanks for the revision! And now, we play the waiting game...

@peppy peppy merged commit eb22655 into ppy:master Sep 8, 2022
@Walavouchey Walavouchey mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Walavouchey Walavouchey Walavouchey left review comments

@peppy peppy peppy approved these changes

@Ephemeralis Ephemeralis Awaiting requested review from Ephemeralis

Assignees
No one assigned
Labels
area:help centre area:translations size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Furdox @peppy @cl8n @Walavouchey