Merged
Conversation
The ones from Font Awesome had a different line thickness, throwing things off a little.
Member
|
New one looks too big to me. Also unfortunate it doesn't have a shadow to match the text. Wondering if we should go for something more impactful like a + inside a circle. I tend to dislike "icons" which are basically just silhouette characters. |
Contributor
Author
Will adjust when pushing the button changes PR osu-side.
I'll see what I can do with that. |
Contributor
Author
|
Something like this maybe? 
On an actual button, with a smaller icon and shadow (still not sure about the exact Also, I suppose it might be better to call these |
Member
|
Sure. I'd argue it's still too big on the button compared to the font but I guess that's adjustable in game-side code. |
LiquidPL
added a commit
to LiquidPL/osu
that referenced
this pull request
Mar 5, 2026
Related to (but shouldn't depend on) ppy#36802. Depends on ppy/osu-resources#408. Pushing this ahead of time mostly to set the new icon on the add to playlist button.
LiquidPL
added a commit
to LiquidPL/osu
that referenced
this pull request
Mar 5, 2026
Related to (but shouldn't depend on) ppy#36802. Depends on ppy/osu-resources#408. Pushing this ahead of time mostly to set the new icon on the add to playlist button.
LiquidPL
added a commit
to LiquidPL/osu
that referenced
this pull request
Mar 5, 2026
Depends on ppy#36802 and ppy/osu-resources#408. Pushing this ahead of time mostly to set the new icon on the add to playlist button.
LiquidPL
added a commit
to LiquidPL/osu
that referenced
this pull request
Mar 5, 2026
Depends on ppy#36802 and ppy/osu-resources#408. This moves out the common layout from `AddToPlaylistFooterButton` to a separate `ShearedFooterButton`, that is intended to be used in other screens which I'm currently working on migrating them to the new footer. It also adds a new 'add' icon to be used on the playlists button. Pushing this ahead of time (without any other buttons using it yet) mostly to get the new icon on the add to playlist button. I've set the icon size to `20`. Could get it smaller, howvever I think it should be a *bit* taller than the button label.
peppy
approved these changes
Mar 5, 2026
LiquidPL
added a commit
to LiquidPL/osu
that referenced
this pull request
Mar 13, 2026
Depends on ppy#36802 and ppy/osu-resources#408. This moves out the common layout from `AddToPlaylistFooterButton` to a separate `ShearedFooterButton`, that is intended to be used in other screens which I'm currently working on migrating them to the new footer. It also adds a new 'add' icon to be used on the playlists button. Pushing this ahead of time (without any other buttons using it yet) mostly to get the new icon on the add to playlist button. I've set the icon size to `20`. Could get it smaller, howvever I think it should be a *bit* taller than the button label.
LiquidPL
added a commit
to LiquidPL/osu
that referenced
this pull request
Mar 23, 2026
Depends on ppy#36802 and ppy/osu-resources#408. This moves out the common layout from `AddToPlaylistFooterButton` to a separate `ShearedFooterButton`, that is intended to be used in other screens which I'm currently working on migrating them to the new footer. It also adds a new 'add' icon to be used on the playlists button. Pushing this ahead of time (without any other buttons using it yet) mostly to get the new icon on the add to playlist button. I've set the icon size to `20`. Could get it smaller, howvever I think it should be a *bit* taller than the button label. # Conflicts: # osu.Game/Screens/OnlinePlay/Playlists/AddToPlaylistFooterButton.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ones from Font Awesome had a different line thickness, throwing things off a little.
I've been working on the footer buttons, and it was bugging me how sad the 'add to playlist' button looks with a '+' character as the icon (and also I wanted to consolidate all the new buttons I've been making under a generic 'sheared button with icon' drawable so having an odd one with an
OsuSpriteTextinstead of an icon would be confusing).These were created in Figma (I can link to my copy of the Master Library thingy elsewhere since I'm not sure if that is supposed to be public), and I did my best to match the style/line thickness/whatever else with the other buttons.
Here's a comparison of the relevant button with and without the new icon:
The minus icon isn't being used anywhere, but it was low hanging fruit enough that it didn't make sense not to include it.