Skip to content

Populate score without mods during ongoing imports & add command for backpopulation of it on existing scores #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented May 21, 2024

This PR ensures that the legacy score watchers populate total_score_without_mods correctly to the json (to match ppy/osu-web#11211), and also features a command to fill in that data wherever it's missing, using an approximate estimate.

Only tested locally on a small scores table, so buyer beware.

@peppy peppy merged commit 09e52da into ppy:master Jul 17, 2024
3 checks passed
@bdach bdach deleted the backpopulate-total-score-without-mods branch July 17, 2024 11:12
@peppy
Copy link
Member

peppy commented Jan 21, 2025

Just a self heads-up that this still needs to be run at some point, with consideration given to table size expansion when it is.

@peppy peppy self-requested a review January 21, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants