Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for macOS ctrl click (right click emulation) #5546

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Nov 26, 2022

Note that this conflicts with ControlPressed cases like control-enter in song select for example. I was hoping to redirect it with cmd but there is also a SuperPressed. Not sure how to handle that.

@peppy
Copy link
Member

peppy commented Nov 26, 2022

Without checking the code, it sounds very weird that this should affect ctrl+enter.

@Joehuu
Copy link
Member Author

Joehuu commented Nov 26, 2022

Never mind, I mistook ctrl-clicking carousel item/logo with ctrl-enter because it's in the same ControlPressed flow in song select.

Not sure if there are other conflicts then (editor?), haven't checked.

@Joehuu Joehuu marked this pull request as draft December 27, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't ctrl+click for right-click on macOS
2 participants