Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Displays querying on every access and add DisplaysChanged #5439

Merged
merged 7 commits into from
Oct 4, 2022
Merged

Fix Displays querying on every access and add DisplaysChanged #5439

merged 7 commits into from
Oct 4, 2022

Commits on Oct 3, 2022

  1. Store Displays and update on change 

    `Displays` are used in a hot path in `UserInputManager.mouseOutsideAllDisplays`
so storing is much more performant than querying SDL every time.
    @Susko3
    Susko3 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    b9ca2fb View commit details
    Browse the repository at this point in the history

  2. Move displayFromSDL to only usage

    @Susko3
    Susko3 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9f5e5e2 View commit details
    Browse the repository at this point in the history

  3. Add DisplaysChanged event

    @Susko3
    Susko3 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d2f1f7c View commit details
    Browse the repository at this point in the history

  4. Use DisplaysChanged in tests

    @Susko3
    Susko3 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    4958f66 View commit details
    Browse the repository at this point in the history

  5. Add assertion to catch cases where displays don't update 

    To support `SequenceEqual` as expected, `Display` equality has to be changed.
This should also make `CurrentDisplayBindable` more accurate when
something other than the index changes.
    @Susko3
    Susko3 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    b324957 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Merge branch 'master' into fix-Displays-allocation

    @peppy
    peppy authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    39cb8dc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-Displays-allocation

    @peppy
    peppy authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    4abcead View commit details
    Browse the repository at this point in the history