Fix crash in SafeAreaContainer when working with negative sizing
#5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% sure this will provide the correct behaviour when negatively sized. It's hard to tell what the expectation would be in this case (sizing the `SafeAreaContainer` in this manner will give completely unexpected results unless it completely ignores the negative component... since the intention of these containers is to handle device edge scenarios). Fixes ppy#5015.
smoogipoo
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure this will provide the correct behaviour when negatively sized. It's hard to tell what the expectation would be in this case (sizing the
SafeAreaContainerin this manner will give completely unexpected results unless it completely ignores the negative component... since the intention of these containers is to handle device edge scenarios).Fixes #5015.