Skip to content

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Dec 7, 2018

ValueChangedEvent<T>:
    <T> OldValue
    <T> NewValue

And also forwards compatible if we ever add anything else to these args (or override them or something).

Interested to hear everyone's thoughts on naming/etc.

@UselessToucan
Copy link
Contributor

You wrote earlier that we don't use EventHandler/EventArgs.

@smoogipoo
Copy link
Contributor Author

@UselessToucan Of course, I can remove it, but EventArgs is a dummy object by itself

@peppy
Copy link
Member

peppy commented Dec 21, 2018

Let's go with ValueChangedEvent to reduce the length of the class and follow what we are using elsewhere (UIEvent for instance).

# Conflicts:
#	osu.Framework.Tests/Visual/TestCaseUserInterface/TestCaseWaveform.cs
#	osu.Framework/Configuration/Bindable.cs
#	osu.Framework/Localisation/LocalisationManager.cs
#	osu.Framework/Platform/GameHost.cs
#	osu.Framework/Testing/Drawables/Sections/ToolbarRateSection.cs
#	osu.Framework/Testing/TestBrowser.cs
@peppy peppy merged commit 9540e43 into ppy:master Feb 21, 2019
@smoogipoo smoogipoo deleted the bindable-eventargs branch May 21, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants