Fix bug when 2 signals in a pair are not perfectly aligned for wavelet coherence#232
Merged
patricefortin merged 1 commit intomasterfrom Jul 11, 2025
Merged
Conversation
There are cases where 2 signals in a pair are not exactly the same length (one sample of difference). In these cases the longest signal is cropped. But when computing intra, we reuse the same signal (not from the pair), so we should load a cropped cached signal.
patricefortin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add length of signal to the wavelet caching key
There are cases where 2 signals in a pair are not exactly the same length (one sample of difference).
In these cases the longest signal is cropped. But when computing intra, we should use the original signal, and not load (from cache) the cropped signal