Merged
Conversation
…w used instead of astropy circmean
…ailed cluster-level statistical permutation test ; simplified the getting_started.ipynb tutorial
README.md
Outdated
| poetry install | ||
| ``` | ||
|
|
||
| ### 4. Enter the Poetry Shell: |
Collaborator
There was a problem hiding this comment.
Should rename this step, something like "Launch jupyter lab to run notebooks", since we no longer use the shell
pyproject.toml
Outdated
| importlib-resources = "^6.0.0" | ||
| statsmodels = "^0.14.4" | ||
| numpy = "^2.2.3" | ||
| jupyterlab = "^4.3.5" |
Collaborator
There was a problem hiding this comment.
I don't think we should put jupyterlab in main dependencies. It is really a "dev" dependency, someone could want to use hypyp as a library without depending on jupyter at all.
Installation steps can be updated to show how to install dev dependencies
…y ; updated readme.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated build rules, poetry 2 and numpy, cleaned code.