fix flaky test and add random seed to have deterministic tests#199
Merged
deep-introspection merged 1 commit intoppsp-team:masterfrom Oct 1, 2024
patricefortin:fix/flaky-test
Merged
fix flaky test and add random seed to have deterministic tests#199deep-introspection merged 1 commit intoppsp-team:masterfrom patricefortin:fix/flaky-test
deep-introspection merged 1 commit intoppsp-team:masterfrom
patricefortin:fix/flaky-test
Conversation
Collaborator
Author
|
This image shows the values of the sum of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In some cases (non deterministic),
test_filtwas failing due to the strategy on PSD comparison.The change here fix the test, and also add a random seed for which the test was failing.