Skip to content

fix: free ets->data on error paths in eaptls_receive and eaptls_free_… #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuammu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: free ets->data on error paths in eaptls_receive and eaptls_free_… #597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pppd/eap-tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,7 @@ void eaptls_free_session(struct eaptls_session *ets)
if (ets->info)
tls_free_verify_info(&ets->info);

free(ets->data);
free(ets);
}

Expand Down Expand Up @@ -888,11 +889,15 @@ int eaptls_receive(struct eaptls_session *ets, u_char * inp, int len)

if (len < 0) {
warn("EAP-TLS: received malformed data");
free(ets->data);
ets->data = NULL;
return 1;
}

if (len + ets->datalen > ets->tlslen) {
warn("EAP-TLS: received data > TLS message length");
free(ets->data);
ets->data = NULL;
return 1;
}

Expand All @@ -907,6 +912,8 @@ int eaptls_receive(struct eaptls_session *ets, u_char * inp, int len)

if (ets->datalen != ets->tlslen) {
warn("EAP-TLS: received data != TLS message length");
free(ets->data);
ets->data = NULL;
return 1;
}

Expand Down
Loading