pptp kernel-mode plugin

[anphsw]

This proposal suggests integrating the accel-pptp code (originally from https://accel-pptp.sourceforge.net/), which has been successfully used in various SOHO routers for many years, into the main pppd branch.
The module supports both client and server modes and uses the pptp module that has been included in the kernel since version 2.6.36.
This integration would eliminate the need for out-of-tree builds and ensure better long-term maintenance and compatibility.

[neheb]

https://github.com/openwrt/openwrt/commits/main/package/network/services/ppp/patches/500-add-pptp-plugin.patch

it appears this has been in OpenWrt since 2012.

[Neustradamus]

@anphsw: A long time ago, we have seen to add patches in upstream :)

• @xosevp 2020-07-11: new ppp release ? #111 (comment)
• me 2020-11-09: new ppp release ? #111 (comment)
• me 2020-11-09: new ppp release ? #111 (comment)
• @jow- 2021-01-04: new ppp release ? #111 (comment)
• me 2021-01-10: new ppp release ? #111 (comment)
• me 2021-01-16: new ppp release ? #111 (comment)
• me 2021-01-28: new ppp release ? #111 (comment)
• me 2021-02-28: new ppp release ? #111 (comment)
• @hauke 2021-02-28: new ppp release ? #111 (comment)
• ...

@LGA1150, @systemcrash, @rsalvaterra, @DragonBluep, @icegood, @PolynomialDivision, @Ansuel, @hauke, @rittere, @dedeckeh, @jow-, @ynezz, @sch-m, @nbd168: Your participation here is welcome :)

[xosevp]

https://github.com/openwrt/openwrt/commits/main/package/network/services/ppp/patches/500-add-pptp-plugin.patch

it appears this has been in OpenWrt since 2012.

The OpenWrt patch is much better than the original code from ACCEL-PPTP. It modernizes and cleans up the codebase by unifying logging with the native pppd API, refactoring internal inter-process communication, and improving parameter handling: ACCEL-PPTP.vs.openwrt.diff.txt

Furthermore, it has been more extensively tested as it is included in prplOS, a standard distribution for residential routers: https://gitlab.com/prpl-foundation/prplos/prplos/-/tree/latest-24.10/package/network/services/ppp/patches

[anphsw]

@xosevp
It seems that patch you mentioned:

• missing server mode fixes (socket leak and dead connections, already applied in this pull)
• changing callmgr* call symantics (why?)
• changes logging way for some situations (maybe it's good)
• adds support for changing pptp_window parameter (is it really used in production?)
• using direct access to ppp_devname instead ppp_set_pppdevnam() (seems like outdated way)