Skip to content

Conversation

@Maestro-Zacht
Copy link
Contributor

Description

Currently if there are test files in a subdir of tests/ they'd be included in the report. For example:

tests/
    dir_a/
        test_a.py
    test_b.py

in this scenario, tests/dir_a/test_a.py would be included in the coverage report.

Type of Change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

@ppfeufer
Copy link
Owner

ppfeufer commented Aug 26, 2025

Nice catch, but wouldn't it be easier to simply exclude */tests/*, so everything in any tests directory is ignored?

I've never looked at that file, as I never had any issues with it, so I don't know if that would be sufficient.

@Maestro-Zacht
Copy link
Contributor Author

Same, I also never looked at it and I only noticed this because of some test files appearing in charlink reports. I didn't think about ignoring the whole dir, I just checked and it still works. I'll make the change

@ppfeufer ppfeufer merged commit 5f7f402 into ppfeufer:master Aug 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants