Skip to content

Improve Vector.update #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2019
Merged

Improve Vector.update #167

merged 2 commits into from
Jun 2, 2019

Conversation

@nicoonoclaste
Copy link
Collaborator

Following #149, Vector.update can be made simpler and faster.

@nicoonoclaste
Copy link
Collaborator Author

This came up while I was adding Vector.zero as a class-level variable, which somehow made dataclasses.update unhappy.

@AstraLuma
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jun 2, 2019
@bors @nicoonoclaste
Merge #167
6113852 
167: Improve Vector.update r=astronouth7303 a=nbraud

Following #149, `Vector.update` can be made simpler and faster.

Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors
Copy link
Contributor

bors bot commented Jun 2, 2019

Build succeeded

  • docs
  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • lint
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@bors bors bot merged commit 48da4c4 into ppb:master Jun 2, 2019
@nicoonoclaste nicoonoclaste deleted the update branch June 2, 2019 14:46
@nicoonoclaste nicoonoclaste mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicoonoclaste @AstraLuma