Skip to content

[Chore] Update Alpha with Master #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
May 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
5c25fcd
Fix issue with re-using a shared Mutex.
rkistner Feb 29, 2024
b665748
Merge pull request #31 from powersync-ja/fix-mutex-reuse
rkistner Mar 5, 2024
5dbcb64
Use busy-timeout for database-level locks.
rkistner Apr 2, 2024
b8a68f9
Revert mutex change.
rkistner Apr 2, 2024
713cb12
Rename to lockTimeout.
rkistner Apr 2, 2024
b8121c2
Bump dart SDK.
rkistner Apr 2, 2024
28cf266
Clarify docs on multiple instances.
rkistner Apr 3, 2024
eef16ad
Add failing test.
rkistner Apr 3, 2024
8417334
Use ClosedException.
rkistner Apr 3, 2024
a722156
Fix "Concurrent modification during iteration" errors.
rkistner Apr 3, 2024
dea8505
Handle ClosedException in SqliteConnectionPool.
rkistner Apr 3, 2024
dd2bce0
Fix race condition in closing.
rkistner Apr 3, 2024
5cf85db
Slightly better handling of connection initialization errors.
rkistner Apr 3, 2024
3b79bce
Cleanup.
rkistner Apr 3, 2024
1af625b
Improve handling of uncaught errors in Isolates.
rkistner Apr 3, 2024
c01e637
Rewrite connection pooling queue.
rkistner Apr 3, 2024
726197f
Re-implement lockTimeout.
rkistner Apr 3, 2024
275b38d
Fix imports.
rkistner Apr 3, 2024
ea27d31
Add notes explaining the different locks.
rkistner Apr 4, 2024
662e578
Merge pull request #34 from powersync-ja/multi-isolates
rkistner Apr 4, 2024
2d59a09
Merge remote-tracking branch 'origin/main' into fix-closing
rkistner Apr 4, 2024
88d042b
Merge branch 'fix-closing' into connectionpool-performance
rkistner Apr 4, 2024
bea5c58
Merge pull request #38 from powersync-ja/connectionpool-performance
rkistner Apr 4, 2024
308076c
v0.6.1
rkistner Apr 4, 2024
9023a7b
Merge pull request #39 from powersync-ja/release/0.6.1
rkistner Apr 4, 2024
34e3161
chore: folder structure changes (#40)
DominicGBauer Apr 16, 2024
761baa4
update from master
stevensJourney May 28, 2024
b5fc3c9
qoutes
stevensJourney May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix race condition in closing.
  • Loading branch information
rkistner committed Apr 3, 2024
commit dd2bce05cca0951ae53f55b9a33e75a01417ffa5
3 changes: 3 additions & 0 deletions lib/src/connection_pool.dart
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ class SqliteConnectionPool with SqliteQueries implements SqliteConnection {
// Create a copy of the list, to avoid this triggering "Concurrent modification during iteration"
final toClose = _readConnections.sublist(0);
for (var connection in toClose) {
// Wait for connection initialization, so that any existing readLock()
// requests go through before closing.
await connection.ready;
await connection.close();
}
// Closing the write connection cleans up the journal files (-shm and -wal files).
Expand Down