-
Notifications
You must be signed in to change notification settings - Fork 11
Prototype for impl with sqlite3_web package #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4c54552
Prototype for impl with sqlite3_web package
simolus3 872f1f6
Merge remote-tracking branch 'upstream/alpha-web-prerelease' into web…
simolus3 e5e2d04
Support locks in shared worker
simolus3 d063f94
Implement autocommit
simolus3 ba23fb9
Fix more web tests
simolus3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Fix more web tests
- Loading branch information
commit ba23fb995b35b4beba454580fd322c18ea822eee
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This test currently is failing due to not throwing an exception if a SQL statement is executed after the transaction has been rolled back. This used to work by checking the state of
autoCommit
here. This does unfortunately perform a call togetAutoCommit
for each executed statement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the semantics you need are "execute if in transaction, otherwise throw", this should be possible with custom requests.
_AsyncSqliteDatabase.handleCustomRequest
has access to the raw database and could implement this request within a single round-trip if necessary.