[Fix] Sqlite import redeclaration #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files incorrectly imported sqlite3 with
#include <sqlite3.h>
instead of using the local#include "sqlite3.h"
.This is mentioned in this issue https://github.com/margelo/react-native-quick-sqlite/issues/12 with the same error present in the upstream codebase https://github.com/margelo/react-native-quick-sqlite/blob/be9235eef7d892ed46177f4d4031cc1a9af723ad/cpp/sqliteBridge.cpp#L13.
This would cause issues when building iOS applications which contained the
sqlite3
pod dependency as the compiler would see other SQLite3 declarations in/usr/include
.Example error:
Testing:
This was tested in an Expo 50 application which uses the
expo-updates
NPM package which depends on thesqlite3
pod. A development package was published and used there. It was verified that the iOS build step completed successfully.