Skip to content

Reset isProcessing when exception is thrown during sync process. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

ScottAtRedHawk
Copy link
Contributor

The isProcessing property needs to be reset if an error is thrown during a sync so that subsequent sync attempts can be made. If it's not reset, then it's always true and will never sync again until the app is closed and re-opened.

Copy link
Contributor

@DominicGBauer DominicGBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and making a PR @ScottAtRedHawk!

@DominicGBauer DominicGBauer merged commit 7e6ab86 into powersync-ja:master Apr 30, 2024
@DominicGBauer
Copy link
Contributor

Your change has been included in version 0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants