Small streaming sync improvements #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes are from my work on bucket priorities, I'm moving some of the generic changes into this PR so that the priorities PR will be easier to review. I also wanted to take a look at grouping multiple
data
lines received from the sync service into a single transaction, but that will only have an impact on many small buckets.So, this:
sealed class
for all lines we might receive from the server instead of using a genericObject
class to represent sync lines.data
lines in quick succession. This PR implements a small optimization to insert them in a single transaction when that happens (previously we'd use one transaction per bucket). This may slightly improve sync times when many tiny buckets are involved.hybridMain
setup spawning a proper socket server.