Fix multi-tab sync issues #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW We currently reconnect on every call to |
stevensJourney
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect()again with different parameters.disconnect()(ordisconnectAndClear()).(2) is to make sure we connect with the latest client parameters. I'm not sure if it's perhaps better to always reconnect when calling
connect()- that's what we do in other SDKs (including native Flutter). However, that may not be optimal when working with multiple tabs, since it would effectively reconnect every time you open a new tab.The last one is specifically an issue when calling
disconnectAndClear(). If other tabs were open, the connection would remain open, despite deleting all data in the database. This caused the app to end up in a weird state.