Skip to content

feat: add SqlCursor function improvements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

DominicGBauer
Copy link
Contributor

@DominicGBauer DominicGBauer commented Feb 5, 2025

Description

  • Allow cursor to use column name to get value by including the following functions that accept a column name parameter:
    getBoolean,getBooleanOptional,getString,getStringOptional, getLong,getLongOptional, getDouble,getDoubleOptional
  • Adapted demos
  • Updated powersync-kotlin package to latest version

Note: The SqlCursor interface to user has not changed

Testing

Added unit tests for SqlCursor changes and ran the demo

@DominicGBauer DominicGBauer changed the title feat: add SqlCursor function improvements WIP feat: add SqlCursor function improvements Feb 5, 2025
@DominicGBauer DominicGBauer self-assigned this Feb 6, 2025
@DominicGBauer DominicGBauer marked this pull request as ready for review February 6, 2025 07:52
@DominicGBauer DominicGBauer changed the title WIP feat: add SqlCursor function improvements feat: add SqlCursor function improvements Feb 6, 2025
Co-authored-by: stevensJourney <51082125+stevensJourney@users.noreply.github.com>
@DominicGBauer DominicGBauer merged commit 566c924 into main Feb 6, 2025
1 check passed
@DominicGBauer DominicGBauer deleted the feat/add-sql-cursor-improvements branch February 6, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants