Avoid nested JSON elements in ps_crud #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To collect local writes, we use
json_object()
to combine column values into a CRUD entry. A problem with this is that, if one of the columns has a JSON subtype,json_object()
writes it as a nested object instead of a string. Following this suggestion, we wrap text column types in a single-argumentconcat
call to drop the subtype.I have not yet checked the performance impact of this. Another approach that unfortunately occurred too late to me may be to re-implement
json_object
in PowerSync, avoiding the nested behavior we don't need. That could potentially be faster.