Move input conversion to source stream #363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the bucket batch API to only accept regular input rows (instead of
SqliteInputRow
s that need additional context to be evaluated). As a consequence, the source streams (BinLogStream
,ChangeStream
,WalStream
) are now responsible for applying the context (which is not a problem because they keep a reference to the sync rules).Applying the conversion as early as possible fixes issues when a
CustomSqliteValue
is used in a primary key, because we'd serialize it to BSON in that case. It also simplifies the bucket implementation just a tiny bit.This also applies a small optimization to
applyRowContext
to avoid copying the row if it contains no custom values.