[Postgres] Fix slot recovery & improve log output #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #150.
When starting replication, there are 4 different scenarios we cater for, depending on whether or not we have already completed the initial snapshot before, and whether or not we have a working logical replication slot.
The regression was in case 4 above - the slot would not get re-created, and replication would remain stuck. It can be triggered by something like replication lag falling too far behind, or anything else that makes the replication slot invalid.
The fix here is to raise a MissingReplicationSlotError error again for that case. That is caught higher up in the process, creates a new replication slot with an incremented index (while keeping the current data active), and then replicating with that new slot.
This PR also makes minor improvements to log output.