Skip to content

[Postgres] Improve timeouts and table snapshots #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2024
Merged

[Postgres] Improve timeouts and table snapshots #152

merged 6 commits into from
Dec 9, 2024

Conversation

rkistner
Copy link
Contributor

@rkistner rkistner commented Dec 6, 2024

Builds on #150.

This configures both TCP keepalive and connection timeouts, to detect broken snapshot connections in around 30 seconds instead of 6 minutes.

This now also uses DECLARE CURSOR and FETCH to fetch data in batches, instead of one large stream. This may reduce the chance of these connections hanging.

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 5e09399

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@powersync/service-core Minor
@powersync/service-types Minor
@powersync/service-image Minor
@powersync/service-module-postgres Minor
@powersync/service-jpgwire Patch
@powersync/service-module-mongodb Patch
@powersync/service-module-mysql Patch
test-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rkistner rkistner marked this pull request as ready for review December 6, 2024 13:25
stevensJourney
stevensJourney previously approved these changes Dec 7, 2024
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rkistner rkistner merged commit f1e9ef3 into main Dec 9, 2024
15 checks passed
@rkistner rkistner deleted the timeouts branch December 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants