Skip to content

Conversation

LucDeCaf
Copy link
Contributor

iOS and android folders shouldn't be necessary anymore, have only checked if removing iOS folders works, not android.

Copy link

changeset-bot bot commented Jan 25, 2025

⚠️ No Changeset found

Latest commit: 88df521

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the change of removing the native projects from this repo. It should no longer be required to have those folder committed.
The same could be done for the Android folders, I tested this and didn't notice any issues.
I'd be happy to approve this PR after it's been updated with the main branch.

@stevensJourney stevensJourney merged commit 7de287f into powersync-ja:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants