This repository was archived by the owner on Jan 12, 2022. It is now read-only.
Prevent NativeVote menu callback from freeing in-use forward handle #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increments the refcount of the private forward. This prevents a crash on Debian 10 and doesn't seem like well-defined behavior.
|
@powerlord pls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick-fix while alliedmodders/sourcemod#1041 gets sorted out.
SourceMod doesn't seem to take kindly to a forward handle being deleted while it's being invoked, which is what
Handler_NV_MapVoteMenudoes withNativeVote.Clear()innativevotes_mapchooser.sp. This seemingly didn't have disastrous consequences until Debian 10.All this does is ensure that the handle remains valid for the duration of the private forward call.