[PLAY-2175] Playbook Website: Add Icons to New Icon Page Dynamically #4778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElisaShapiro
added
milano
nickamantia
approved these changes
Jun 18, 2025
nidaqg
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-2175 updates the newly added Icon Page from PLAY-1448 at
../playbook_iconsto get its Icon + Category information from the playbook-icons repo dynamically with a script.The script extracts each icon's name and category, serializes it into JSON, and writes it to app/assets/icons.json. The controller parses icon.json, groups icons by category, and passes it to the view. The script runs whenever
yarn installis run (locally/in CI).Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.minor,major, orpatchlabel for release.inactive RClabel if not an active RC.