Skip to content

[SHD-1959] Reactive audience recalculation #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented Jun 21, 2025

SHD-1359

This pull request introduces significant changes to the audiences context and criteria/group association logic, refactoring how group criteria are handled, stored, and queried. Here’s a summary of the main changes:

  • Moves from storing group info as JSON directly on criteria to a proper join table (audiences_criterion_groups).
  • Refactors queries, associations, and serialization to use ActiveRecord associations.
  • Updates controller, model, and test code accordingly.
  • Adds new database migrations for the join table and column rename.
  • Cleans up and improves group membership notification logic.

@xjunior xjunior force-pushed the criterion-groups branch from 8de265f to a253efd Compare June 21, 2025 01:00
@xjunior xjunior mentioned this pull request Jun 23, 2025
@xjunior xjunior force-pushed the criterion-groups branch from a253efd to 1e30b6c Compare June 23, 2025 13:08
@xjunior xjunior marked this pull request as ready for review June 23, 2025 13:17
@xjunior xjunior requested review from a team as code owners June 23, 2025 13:17
@xjunior xjunior changed the title criterion groups [SHD-1959] Reactive audience recalculation Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant