Skip to content

Commit

Permalink
nodeplugin DaemonSet: removed preStop hook in node-driver-registrar
Browse files Browse the repository at this point in the history
This was used to remove the registration socket when the container
node-driver-registrar container stops. As of [1] it's done by
the registrar itself, making this hook not needed anymore.

[1] kubernetes-csi/node-driver-registrar#61
  • Loading branch information
gman0 authored and lingxiankong committed Aug 15, 2021
1 parent 72af0b4 commit 8dd4ba4
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions charts/manila-csi-plugin/templates/nodeplugin-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,6 @@ spec:
args:
- "--csi-address=/csi/csi.sock"
- "--kubelet-registration-path=/var/lib/kubelet/plugins/{{ printf "%s.%s" .protocolSelector $.Values.driverName | lower }}/csi.sock"
lifecycle:
preStop:
exec:
command: [
"/bin/sh", "-c",
'rm -rf /registration/{{ printf "%s.%s" .protocolSelector $.Values.driverName | lower }}
/registration/{{ printf "%s.%s" .protocolSelector $.Values.driverName | lower }}-reg.sock'
]
env:
- name: KUBE_NODE_NAME
valueFrom:
Expand Down

0 comments on commit 8dd4ba4

Please sign in to comment.