Topic/story 30008 tag publishing and version bumping #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfraiteur
requested changes
Mar 30, 2022
| return true; | ||
| } | ||
|
|
||
| private static bool TagLastCommit( BuildContext context, Version? version, string? packageVersionSuffix ) |
|
|
||
| if ( lastVersion > currentVersion ) | ||
| { | ||
| context.Console.WriteError( $"Last tag version '{lastVersion}' is bigger than current version '{currentVersion}'" ); |
| versionNumber = lastVersionTag.Substring( 0, lastVersionTag.IndexOf( '-', StringComparison.InvariantCulture ) ); | ||
| } | ||
|
|
||
| var lastVersion = new Version( versionNumber ); |
There was a problem hiding this comment.
Version can contain suffixes such as "-preview". By convention, all our version numbers before the dash are are unique, i.e. given a version x.y-z1, we never have x.y-z2.
| return false; | ||
| } | ||
|
|
||
| File.WriteAllText( |
There was a problem hiding this comment.
Use XDocument to load, update, save the file.
| return true; | ||
| } | ||
|
|
||
| private static bool GetTeamCitySourceWriteToken( out string environmentVariableName, [NotNullWhen( true )] out string? teamCitySourceWriteToken ) |
| @@ -17,6 +17,7 @@ public void GenerateTeamcityCode( TextWriter writer ) | |||
| vcs {{ | |||
| watchChangesInDependencies = {this.WatchChangesInDependencies.ToString().ToLowerInvariant()} | |||
| branchFilter = ""+:<default>"" | |||
| triggerRules = ""-:comment=<<VERSION_BUMP>>:**"" | |||
| return true; | ||
| } | ||
|
|
||
| if ( !IsVersionBumped( context, currentVersion, lastVersionTag ) ) |
aweneer
force-pushed
the
topic/story-30008-tag-publishing-and-version-bumping
branch
from
d91b86a to
7295d46
Compare
gfraiteur
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.