Added support for options in CLI converter. #300
Conversation
VShingala
force-pushed
the
feature/cli-options
branch
3 times, most recently
from
af4e843 to
c08048d
Compare
VShingala
force-pushed
the
feature/cli-options
branch
from
33c7218 to
02ee264
Compare
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
It's just an example of how option config can be used. Not used anywhere.
| @@ -0,0 +1,18 @@ | |||
| id|type|available options|default|description|usage | |||
bin/openapi2postmanv2.js
Outdated
| } | ||
| } | ||
| else { | ||
| console.warn('\x1b[33m%s\x1b[0m', 'Warning: Invalid defined option ', option[0]); |
There was a problem hiding this comment.
definedOptions terminology seems confusing to me. These options are something the user supplies through the cli right?
We can probably omit the word defined and just have: Warning: Invalid option or maybe Warning: Invalid option supplied ?
There was a problem hiding this comment.
Hmm, Warning: Invalid option supplied looks good. 👍
umeshp7
left a comment
umeshp7
left a comment
There was a problem hiding this comment.
Small change in logging required.
|
Is this one going to be merged into the base branch soon? I've got a pull request that adds a couple more options, and want to do them the new way. Also will need to re-work #303 to fit in with the new way of doing options from the command line. |
This PR adds support for options during CLI conversion and also adds documentation for the same. Uses some logic from #218.