Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 3, 2020

This addresses @umeshp7's comments from #218, cc: @FrazerBayley @thim81

kevinswiber and others added 6 commits May 31, 2020 03:47
@ghost ghost closed this Aug 5, 2020
@thim81
Copy link
Contributor

thim81 commented Aug 6, 2020

@rockywarren-vertex
Stupid question: Do you close it, which means it is approved, so that it can be merge? Or do you wait for approval, to close it?

@arlemi
Copy link
Collaborator

arlemi commented Aug 6, 2020

@thim81 We can only approve opened PRs, and only approved PRs can be merged. I'm not sure why @rockywarren-vertex closed the PR in this case...

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants