Skip to content

Conversation

@thim81
Copy link
Contributor

@thim81 thim81 commented Jun 5, 2020

#204 Added support for path variables, using examples based on the configuration option "requestParametersResolution"

To support the proper usage, it would suggested to allow the management convertion configurations using a "config" file, like proposed in #218

…d on the configuration option "requestParametersResolution"
@thim81 thim81 mentioned this pull request Jun 5, 2020
@VShingala
Copy link
Member

@thim81 Thanks for the contribution.

We are working on improving example value for requestParameterResolution and exampleParameterResolution options. You can checkout this PR which includes support for this.

For detail, when option requestParameterResolution is set to example, we will now use example property from OpenAPI spec value same as in other properties (i.e. header), and if example is not present in OpenAPI spec then example will be a faked value based on actual schema specified for property.

Do let me know any problems with PR if any, otherwise we can close this issue.

@thim81
Copy link
Contributor Author

thim81 commented Jun 8, 2020

@VShingala Will this improvement also will cover the "path variables"?

Since the "examples" where handled by the option "exampleParameterResolution" and "exampleParameterResolution" for the query parameters & requests body. The existing configuration option did handle the "path variables" properly and always showed it the schema values.

@VShingala
Copy link
Member

@thim81 Yes, it will cover path variables. Previously path variables always resolved to schema but now it will use option requestParameterResolution to select between schema or example.

@thim81
Copy link
Contributor Author

thim81 commented Jun 8, 2020

@VShingala I hope that PR #218 will get accepted since option management for CLI usage is currently not existing.

@thim81
Copy link
Contributor Author

thim81 commented Jun 8, 2020

I'll abandon & close this PR as soon your PR #227 gets accepted and merged.

@thim81
Copy link
Contributor Author

thim81 commented Jun 15, 2020

PR is abandoned, since the behaviour was resolved the 1.2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants