Strict request matching for validation. #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitkane
reviewed
Jun 4, 2020
lib/options.js
Outdated
| id: 'strictRequestMatching', | ||
| type: 'boolean', | ||
| default: false, | ||
| description: 'Whether schema operations be strictly matched with collection request or not.', |
Member
There was a problem hiding this comment.
the or not is redundant
Also, the requests are matched with operations, not the other way round
Whether requests should be strictly matched with schema operations. Setting to true will not include any matches where the URL path segments don't match exactly.
abhijitkane
reviewed
Jun 4, 2020
lib/schemaUtils.js
Outdated
| matchScore: schemaMatchResult.score, | ||
| pathVars: schemaMatchResult.pathVars | ||
| pathVars: schemaMatchResult.pathVars, | ||
| fixMatchedSegments: schemaMatchResult.fixMatchedSegments, |
abhijitkane
reviewed
Jun 4, 2020
| fixMatchedSegments++; | ||
| } | ||
|
|
||
| // for variable match increase variable matched segments count (used for determining order for multiple matches) |
Member
There was a problem hiding this comment.
for /a/b/{{c}} and /a/b/{{c}}, is the fixMatchedSegments value supposed to be 2 or 3? If 2, the check should be moved after the variables check, right?
also, rename to fixedMatchedSegments everywhere
Member
Author
There was a problem hiding this comment.
Yeah it would be 3 here, Moving fixMatchedSegments check after and in else if statements to variableMatchedSegments segment. so only one of them is valid per segment.
…estMatching and updated variable matching to be priorotized over fixed matching
Added support for missing endpoints in collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces option
strictRequestMatchingused for improved validation.