docker: improve NEWMAN_VERSION check in Dockerfiles #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check the result of grep -q instead of testing the output of grep -o; it's shorter, and in my opinion less cryptic - in ash, echo doesn't interpret escape sequences; echo -e does, but printf is more portable anyway
Codecov Report
@@ Coverage Diff @@
## develop #2720 +/- ##
========================================
Coverage 91.55% 91.55%
========================================
Files 21 21
Lines 1113 1113
Branches 339 339
========================================
Hits 1019 1019
Misses 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few issues with the check (plus a typo in comment).
echo $NEWMAN_VERSIONwasn't quoted, so if it started with whitespace, the check would pass. Later thenpm installwould of course fail, but if there's a sanity check, it should catch corner cases as well.The
ifcondition had unnecessary square brackets (test). Replaced with direct use ofgrep -qresult.On Alpine,
echoby default doesn't interpret escape sequences, so the error message didn't show up red, but surrounded with garbage. Replaced withprintf.I didn't touch the Dockerfiles in deprecated alpine33 and ubuntu1404, assuming it's not worth fixing those.