remove duplicated "X-Forwarded-For" from ENV_HEADERS #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
Hi @georgexsh, thanks for this. If you wouldn't mind leaving this as a tuple for consistency, I think this is ready to merge after that.
|
@nateprewitt alright, but IMHO, remove those so-called "ENV_HEADERS" is a terrible idea from the beginning. I have been fooled more once why some important header disappeared. ref #513 |
|
Thanks @georgexsh! This was added by Kenneth as part of his setup routine, I'll defer to him on whether it persists going forward. |
nateprewitt
approved these changes
Oct 24, 2018
|
@nateprewitt thanks, I have noticed that this behavior exists from the beginning, nevertheless, it should be documented. |
virgiliojr94
pushed a commit
to virgiliojr94/httpbin-chat2desk
that referenced
this pull request
Jul 1, 2023
remove duplicated "X-Forwarded-For" from ENV_HEADERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.