Revert #457 "Support show_env param in /headers"
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#457. Fixed postmanlabs#487. The docstring typo fixes are retained, along with the additional tests, modified to revert to the original "headers": { dict format. The reverted change get_dict('headers') -> get_headers() was not required. The query-string ?show_env=1 was already effective in allowing env headers to be returned. This partially reverts commit 31ffe79.
javabrett
changed the title
show_env param in /headers"show_env param in /headers"
|
Hi @javabrett, Yes, your analysis is accurate indeed. I guess we can revert the change to the view logic if we need to retain the existing dict format. I guess we missed that while discussing on my PR the last time around. |
|
👍 |
|
✨🍰✨ |
|
deployed. |
virgiliojr94
pushed a commit
to virgiliojr94/httpbin-chat2desk
that referenced
this pull request
Jul 1, 2023
…vert-457 Revert postmanlabs#457 "Support `show_env` param in `/headers`"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #457. Fixes #487.
The docstring typo fixes are retained, along with the additional tests,
modified to revert to the original
"headers": {dict format.The reverted change
get_dict('headers')->get_headers()was not required. Thequery-string
?show_env=1was already effective in allowing env headers to bereturned.
This partially reverts commit 31ffe79.
That this change was not required (other than the tests, thanks) was hinted-at by @nateprewitt in the review for #457:
In fact the
show_envpass-through option for filtered env headers has been there since that feature was added in bb094d4 .@sanketsaurav please chime-in here if this analysis seems off. Your PR might have fixed something for you. /cc @Fishbowler .