Skip to content

Async PG support #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Async PG support #412

wants to merge 3 commits into from

Conversation

levkk
Copy link
Contributor

@levkk levkk commented Apr 22, 2023

Fix #396

@levkk levkk changed the title Async Async PG support Apr 22, 2023
@levkk levkk added the wip Work in progress label Apr 22, 2023
@levkk levkk marked this pull request as draft April 22, 2023 15:27
@@ -1141,9 +1166,14 @@ where

// Sync
// Frontend (client) is asking for the query result now.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to update these docs to include Flush. Something like:

                    // Sync (S)
                    // Frontend (client) is asking for the query result now.
                    // ... or ...
                    // Flush (H)
                    // Frontend (client) is asking for server to send query results now without
                    // sync.

@film42
Copy link

film42 commented May 27, 2023

This looks pretty good to me. Conflicts should be pretty easy to resolve. Is there something about this that you don't love that keeps this in a draft state?

@levkk
Copy link
Contributor Author

levkk commented May 27, 2023

I don't think it actually works. I tested it locally, but it fails in CI. Haven't had time to investigate further yet.

@martiGIT
Copy link

Hi, any update with this issue, I have similar problem when running this with python code. Thanks for update

@estubmo
Copy link

estubmo commented Mar 17, 2024

Would love a progress update on this one

)
.await
{
let message = tokio::select! {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this idea trying to see if this helps with #303

Something else it's missing that doesn't allow to send the server messages to the client. Maybe this 2 issues are related and could be solved both with the same fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pgcat is not working with asyncpg python client and I am getting this error in logs ERROR pgcat::client] Unexpected code: H
5 participants