Ruby integration tests #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdrsh
commented
Aug 26, 2022
tests/ruby/misc_spec.rb
Outdated
Comment on lines
5
to
19
| describe "Miscellaneous" do | ||
| let(:proxies) { Helpers::Pgcat.single_shard_setup("sharded_db", 5) } | ||
|
|
||
| describe "Clients closing connection in the middle of transaction" do | ||
| it "sends a rollback to the server" do | ||
| conn = PG::connect(proxies.main.connection_string("sharded_db", "sharding_user")) | ||
| conn.async_exec("SET SERVER ROLE to 'primary'") | ||
| conn.async_exec("BEGIN") | ||
| proxies.primary.begin_counting_queries | ||
| conn.close | ||
| sleep 0.5 | ||
| # ROLLBACK, DISCARD ALL, SET application_name | ||
| expect(proxies.primary.end_counting_queries).to eq(3) | ||
| end | ||
| end |
There was a problem hiding this comment.
This would be difficult to verify by looking at stats or logs of the main process because we don't increment stats for recovery ROLLBACK.
Putting another proxy between the database and pgcat and inspecting its logs will give us an idea what is actually being sent by the main Pgcat process
jmeagher
pushed a commit
to jmeagher/pgcat
that referenced
this pull request
Feb 17, 2023
Exit with failure codes if configs are bad (postgresml#146) Move autoreloader to own tokio task (postgresml#148) Ruby integration tests (postgresml#147) Allow running integration tests with coverage locally (postgresml#151) Log Address information in connection create/drop (postgresml#154) Better handling for checkout errors during extended protocol messages (postgresml#155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use 4 separate instances of Postgres and use
pg_stat_statementsto validate Pgcat's routing decisions.This contains some convenience classes that allows us to control the Pgcat process under test, apply toxics to communication with database and count queries on Postgres side.