Skip to content

Conversation

@Roemer
Copy link
Member

@Roemer Roemer commented Oct 16, 2025

No description provided.

@Roemer Roemer force-pushed the feature/sonar-scanner-cli branch from 42de7a7 to 3503adc Compare October 16, 2025 16:31
@mailaenderli
Copy link
Contributor

mailaenderli commented Oct 20, 2025

We need to implement IsFullVersion, since its not a semver. Like here:

func (c *chromeComponent) IsFullVersion(referenceVersion *gover.Version) bool {

@mailaenderli mailaenderli self-requested a review October 20, 2025 12:46
@Roemer Roemer force-pushed the feature/sonar-scanner-cli branch from 3503adc to f6bd185 Compare October 20, 2025 14:52
@Roemer
Copy link
Member Author

Roemer commented Oct 20, 2025

We need to implement IsFullVersion, since its not a semver. Like here:

func (c *chromeComponent) IsFullVersion(referenceVersion *gover.Version) bool {

Added

@Roemer Roemer force-pushed the feature/sonar-scanner-cli branch from f6bd185 to 32f6633 Compare October 20, 2025 14:55
@Roemer Roemer force-pushed the feature/sonar-scanner-cli branch from 32f6633 to aa801c0 Compare October 20, 2025 15:09
@Roemer Roemer merged commit 9d52d26 into main Oct 20, 2025
21 checks passed
@Roemer Roemer deleted the feature/sonar-scanner-cli branch October 20, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants