Skip to content

Commit

Permalink
Rename field name to commits_for_next_block
Browse files Browse the repository at this point in the history
  • Loading branch information
fakedev9999 authored and junha1 committed Feb 23, 2023
1 parent 778f78e commit 9d5b9ed
Showing 1 changed file with 22 additions and 12 deletions.
34 changes: 22 additions & 12 deletions common/src/verify.rs
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ pub struct CommitSequenceVerifier {
header: BlockHeader,
phase: Phase,
reserved_state: ReservedState,
next_block_commits: Vec<Commit>,
commits_for_next_block: Vec<Commit>,
total_commits: Vec<Commit>,
}

Expand All @@ -132,7 +132,7 @@ impl CommitSequenceVerifier {
header: start_header.clone(),
phase: Phase::Block,
reserved_state,
next_block_commits: vec![],
commits_for_next_block: vec![],
total_commits: vec![Commit::Block(start_header)],
})
}
Expand Down Expand Up @@ -184,7 +184,7 @@ impl CommitSequenceVerifier {
verify_header_to_header(&self.header, block_header)?;
// Verify commit merkle root
let commit_merkle_root =
BlockHeader::calculate_commit_merkle_root(&self.next_block_commits);
BlockHeader::calculate_commit_merkle_root(&self.commits_for_next_block);
if commit_merkle_root != block_header.commit_merkle_root {
return Err(Error::InvalidArgument(format!(
"invalid commit merkle root: expected {}, got {}",
Expand All @@ -193,7 +193,7 @@ impl CommitSequenceVerifier {
};
self.header = block_header.clone();
self.phase = Phase::Block;
self.next_block_commits = vec![];
self.commits_for_next_block = vec![];
}
(
Commit::Block(block_header),
Expand All @@ -211,7 +211,7 @@ impl CommitSequenceVerifier {
}
// Verify commit hash
let commit_merkle_root =
BlockHeader::calculate_commit_merkle_root(&self.next_block_commits);
BlockHeader::calculate_commit_merkle_root(&self.commits_for_next_block);
if commit_merkle_root != block_header.commit_merkle_root {
return Err(Error::InvalidArgument(format!(
"invalid commit merkle root: expected {}, got {}",
Expand All @@ -220,7 +220,7 @@ impl CommitSequenceVerifier {
};
self.header = block_header.clone();
self.phase = Phase::Block;
self.next_block_commits = vec![];
self.commits_for_next_block = vec![];
}
(Commit::Transaction(tx), Phase::Block) => {
// Update reserved_state for reserved-diff transactions.
Expand Down Expand Up @@ -435,7 +435,7 @@ impl CommitSequenceVerifier {
));
}
}
self.next_block_commits.push(commit.clone());
self.commits_for_next_block.push(commit.clone());
self.total_commits.push(commit.clone());
Ok(())
}
Expand Down Expand Up @@ -787,7 +787,9 @@ mod test {
previous_hash: Commit::Block(csv.header.clone()).to_hash256(),
height: csv.header.height + 2,
timestamp: 2,
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(&csv.next_block_commits),
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(
&csv.commits_for_next_block,
),
repository_merkle_root: Hash256::zero(),
validator_set: validator_keypair
.iter()
Expand Down Expand Up @@ -828,7 +830,9 @@ mod test {
previous_hash: Hash256::zero(),
height: csv.header.height + 1,
timestamp: 2,
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(&csv.next_block_commits),
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(
&csv.commits_for_next_block,
),
repository_merkle_root: Hash256::zero(),
validator_set: validator_keypair
.iter()
Expand Down Expand Up @@ -869,7 +873,9 @@ mod test {
previous_hash: Commit::Block(csv.header.clone()).to_hash256(),
height: csv.header.height + 1,
timestamp: 2,
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(&csv.next_block_commits),
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(
&csv.commits_for_next_block,
),
repository_merkle_root: Hash256::zero(),
validator_set: validator_keypair
.iter()
Expand Down Expand Up @@ -910,7 +916,9 @@ mod test {
previous_hash: Commit::Block(csv.header.clone()).to_hash256(),
height: csv.header.height + 1,
timestamp: -1,
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(&csv.next_block_commits),
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(
&csv.commits_for_next_block,
),
repository_merkle_root: Hash256::zero(),
validator_set: validator_keypair
.iter()
Expand Down Expand Up @@ -998,7 +1006,9 @@ mod test {
previous_hash: Commit::Block(csv.header.clone()).to_hash256(),
height: csv.header.height + 1,
timestamp: 2,
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(&csv.next_block_commits),
commit_merkle_root: BlockHeader::calculate_commit_merkle_root(
&csv.commits_for_next_block,
),
repository_merkle_root: Hash256::zero(),
validator_set: validator_keypair
.iter()
Expand Down

0 comments on commit 9d5b9ed

Please sign in to comment.