Fix copy with no hash #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hey, @johnagan same problem here! Since I don't think this PR will be merged anytime soon, what's the solution you are using in the meantime? |
thisconnect
reviewed
Jan 17, 2022
| const assetRelativePath = options.useHash | ||
| ? getHashName(file, options.hashOptions) | ||
| : asset.relativePath; | ||
| : path.basename(file.path); |
There was a problem hiding this comment.
could you add a test that fails without this commit and passes with it?
TigersWay
added a commit
to TigersWay/postcss-url
that referenced
this pull request
Jun 28, 2022
Never applied postcss#146
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize this repo isn't touched often, but I think it's a great plugin.
I came across an issue where if I used
copyand{ useHash: false }it wouldn't copy the file. Took me longer to diagnose than it did to fix.Basically the existing code is referencing the full path to the existing file, unless it's replaced with a hashed filename. So I just replace the full path with the basename of the file.