Include schema name on each change #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| empty_oid, | ||
| datum); | ||
| let json = | ||
| pg::DirectFunctionCall1Coll(Some(row_to_json), empty_oid, datum); |
There was a problem hiding this comment.
rustfmt was complaining about this, but I can add on a different PR.
There was a problem hiding this comment.
Totally fine. I remember having seen that one. Thank you for fixing it.
|
We should flip the order of |
|
+1 |
|
Err +1 on solid's comment |
|
I will do that then. Not sure why the tests are failing on travis - they pass locally. I'll take a look. |
|
@ruimarinho It fails because some tests are missing relative to master. If you rebase and include results from the new tests it should fix the issue. |
|
Please rebate this |
ruimarinho
force-pushed
the
enhancement/include-schema-name-on-each-change
branch
from
85eab1a to
13e1ea0
Compare
|
Rebased and also inverted order of schema and table fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the schema name on each change so that there is no need to store state between changes.
Not sure if "schema name" or "table name" is more appropriate for this PR.